Fix issue 976

[ericvergnaud]

Doesn't actually fix anything, rather adds tests that show that a fix might not be required Progresses #976

[github-actions[bot]]

Coverage tests results

456 tests  +6   419 ✅ +3   4s ⏱️ ±0s   6 suites ±0    37 💤 +3    6 files   ±0     0 ❌ ±0 

Results for commit 1ec1904d. ± Comparison against base commit 2b3d5f67.

This pull request removes 9 and adds 15 tests. Note that renamed tests count towards both.

``` com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_to_time/test_to_time_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_to_time/test_to_time_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_try_to_date/test_try_to_date_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/test_try_to_date/test_try_to_date_3.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/conversion/to_timestamp_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/dayname/test_dayname_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/monthname/test_monthname_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/test_date_trunc_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ functions/dates/test_date_trunc_3.sql ``` ``` com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ arrays/test_array_construct_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ arrays/test_array_construct_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ arrays/test_arrayagg_8.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ arrays/test_arrayagg_9.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_to_time_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_to_time_2.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_try_to_date_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/test_try_to_date_3.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/to_timestamp_1.sql com.databricks.labs.remorph.coverage.SnowflakeAcceptanceSuite ‑ core_engine/functions/conversion/to_timestamp_variable_format.sql … ```

:recycle: This comment has been updated with latest results.

[ericvergnaud]

LGTM, you may want to run make fmt-scala locally to please the CI gods

done

[sundarshankar89]

@ericvergnaud can you rewrite commits as signed, auto merge doesn't work without that.

[jimidle]

It looks like some of your commits were not signed. You may have to redo the PR if they cannot be signed after the push.

Also, can you rename the PR to say what it is actually fixing and reference the ticket.

[ericvergnaud]

@gueniai this PR is blocked due to gpg-signing requirement. I wasn't aware of this requirement (we don't have it on ucx) Despite my efforts to post-sign previous commits, the PR is still blocked. Are you able to validate the PR ? If not I have to recreate it... Same for #1225 and #1226... I have now setup gpg-signing so this should no longer be an issue, but my pre-existing commits seem to be blocked forever

[ericvergnaud]

Closed in favor of #1237