Closed fatemag-crest closed 1 year ago
Merging #41 (5d97de1) into master (c59ef74) will decrease coverage by
5.36%
. The diff coverage is70.22%
.:exclamation: Current head 5d97de1 differs from pull request most recent head 927fb26. Consider uploading reports for the commit 927fb26 to get more accurate results
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 86.40% 81.05% -5.36%
==========================================
Files 8 9 +1
Lines 618 760 +142
==========================================
+ Hits 534 616 +82
- Misses 84 144 +60
Impacted Files | Coverage Δ | |
---|---|---|
app/bin/databricks_get_credentials.py | 51.72% <51.72%> (ø) |
|
app/bin/databricks_validators.py | 74.00% <60.00%> (-13.50%) |
:arrow_down: |
app/bin/databricks_common_utils.py | 86.58% <79.54%> (-0.49%) |
:arrow_down: |
app/bin/databricksquery.py | 81.91% <90.00%> (+0.19%) |
:arrow_up: |
app/bin/databricks_com.py | 88.63% <95.23%> (+0.17%) |
:arrow_up: |
app/bin/databricksjob.py | 100.00% <100.00%> (ø) |
|
app/bin/databricksretiredrun.py | 52.63% <100.00%> (+0.84%) |
:arrow_up: |
app/bin/databricksrun.py | 100.00% <100.00%> (ø) |
|
...n/ta_databricks/modalert_launch_notebook_helper.py | 100.00% <100.00%> (+4.76%) |
:arrow_up: |
@fatemag-crest please add more tests, as this PR won't be merged without meeting the quality targets
@alexott - We had this discussed with Zafer, and he confirmed we are good with the current coverage which is 81.05%. The required coverage is 80% as mentioned here.
Can you check why GitHub is failing this even if the coverage is above the mentioned limit?
Updated the Add-on to allow non-admin users to execute the custom commands. Added support for mutiple account creation. Updated the user-agent to include logged in user. Updated Unit test cases.