search

datacarpentry / NEON-R-Tabular-Time-Series

These data tutorials complement the spatio-temporal lessons (raster and vector) in R lessons. These lessons are close to being published on the neondataskills.org website.
http://neon-workwithdata.github.io/NEON-R-Tabular-Time-Series
6 stars 6 forks source link

Culmination Activity: Error in Code (strsplit) #91

Closed mjones01 closed 8 years ago

mjones01 commented 8 years ago

Final activity in lesson isn't plotting ( ## Error in strsplit(unitspec, " "): non-character argument ).
Very last line of the lesson.

http://data-lessons.github.io/NEON-R-Tabular-Time-Series//R/Work-With-NDVI-and-Met-Data-In-R

lwasser commented 8 years ago

it figures it's the last line. I'll have a look. it's probably some weird R quirk and sometimes fresh eyes are the ticket to a quick solution.

mjones01 commented 8 years ago

L04 and L06 are also throwing errors in their last challenge activity, however, the plots look fine. I'm going to stick to the yml and .md edits for now. I think I'd mess too much up if switching to content right now.

lwasser commented 8 years ago

Good call - breaks are good. I'll have a look when I do the rebuild of all repos with the new template items. Thanks for posting this issue!

lwasser commented 8 years ago

Ok - issue above -- a quick search on the error lead me to the documentation for the scale_x_date.

https://github.com/hadley/ggplot2/blob/master/man/scale_date.Rd

The code was breaking at the breaks part. And the error was suggesting it didnt understand the format. the fix:

date_breaks = "3 months",
date_minor_breaks= "1 week",

Instead of breaks= minor_breaks=

I just looked at the documentation for scale_x_date and saw there were date specific break elements. 1 is fixed! :)

lwasser commented 8 years ago

Ok - i need to have a closer look at this lesson. the y axis labels are super crunched and it's not rendering right but the code is all working! let's leave this open for now.

lwasser commented 8 years ago

L04 issue -- code had an addition = sign ylab=="Precip (mm)"

fix ylab="Precip (mm)"

qplot(x=total.prec2$datetime, y=total.prec2$sum_prec,
    main="Total Daily Precipitation 2009-2011\nNEON Harvard Forest Field Site",
    xlab="Date (Daily Values)", ylab=="Precip (mm)")

fixed.

lwasser commented 8 years ago

@mjones01 these issues have been FIXED. I am closing this issue. 634c955d12ff15f5592d52df50d9c993667d7d28