datacarpentry / image-processing

Image Processing with Python
https://datacarpentry.org/image-processing
Other
103 stars 124 forks source link

Create section about image loading. #311

Closed mkcor closed 1 year ago

mkcor commented 1 year ago

Closes #242.

After discussing with the other @datacarpentry/curriculum-advisors-image, I have reorganized the beginning of episode 02 (Image Basics) to include a "Loading images" section.

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-311

The following changes were observed in the rendered markdown documents:

 02-image-basics.md | 134 ++++++++++++++++++++++++++++++++++-------------------
 md5sum.txt         |   2 +-
 2 files changed, 88 insertions(+), 48 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-12-09 16:04:26 +0000

mkcor commented 1 year ago

As mentioned before, with a109ed5, I've included this note by @soupault, adapting it slightly to fit the context of the lesson.

mkcor commented 1 year ago

Thanks @mkcor I like this. Making only one suggestion, to include the output of the call to type

Sure, thank you!