datacarpentry / r-raster-vector-geospatial

Introduction to Geospatial Raster and Vector Data with R
https://datacarpentry.org/r-raster-vector-geospatial
Other
113 stars 111 forks source link

write new content for interactive plotting with leaflet #134

Open ErinBecker opened 6 years ago

ErinBecker commented 6 years ago

Leah has a sample lesson that she can provide to show one possible way of implementing this.

@lwasser - could you please put the link to the sample lesson in this issue?

lwasser commented 6 years ago

Here you go

https://earthdatascience.org/courses/earth-analytics/get-data-using-apis/leaflet-r/

i think i may have another one somewhere but this is a start.

lwasser commented 6 years ago

adding @tyson-swetnam to this conversation! @ErinBecker why can't i add him as an assignee since he is working on the lesson? just curious. it's nice if people see someone is working on htis actively

ErinBecker commented 6 years ago

@tyson-swetnam hasn't accepted the invite to join the geospatial-maintainers team yet, and so he can't be assigned issues. I've emailed him just now to remind him about the invite. Should be able to start assigning him work soon!!

lwasser commented 6 years ago

ok wonderful. i was wondering what that is about!! thanks @ErinBecker he is working on this lesson which is super awesome!!

tyson-swetnam commented 6 years ago

Sorry @ErinBecker somehow I missed seeing the invite in my Github. I'm here now!

tyson-swetnam commented 6 years ago

@ErinBecker Plotting with Leaflet instead of plot() could impact the entire rastor/vector lesson structure. It would be less work to just introduce Leaflet as a new Lesson (15). On the other hand, if we integrated it as a major revision to the lessons starting with Lesson 2 (Plotting Rasters) and Lesson 6 (Opening Shapefiles in R) it could eventually make its way into all of the lessons.

Thoughts?

tyson-swetnam commented 6 years ago

Here are the rstudio leaflet lessons: https://rstudio.github.io/leaflet/

lwasser commented 6 years ago

we are not replacing plotting throughout @tyson-swetnam we are adding a new lesson on interactive plotting :)

lwasser commented 6 years ago

in a separate issue we are replacing plot() wtih ggplot () throughout. that is static plotting.

lwasser commented 6 years ago

@ErinBecker i'm wondering if we need to write very explicit issues that explain a bit of what we are trying to do with each new set of edits and what was discussed in the meetings? otherwise i think everyone may get confused :) and rightfully so as they weren't at all of the discussions which makes some tasks confusing but it's a nice way to save everyone's time!!

ErinBecker commented 6 years ago

@lwasser - I agree. It would be good to write up more detailed issues. I assumed that the meeting minutes were sufficient background, but I probably have some blind spot there since I was at the meetings!

ErinBecker commented 6 years ago

@lwasser - I've got back to back meetings starting soon. Would you be able to write some more detailed issues for the Maintainers so they know what the next steps are?

lwasser commented 6 years ago

I can work on this a bit tomorrow or maybe tonight! I’m in the same camp tho – meetings this afternoon and a presentation. ☺

ErinBecker commented 6 years ago

I'll see what I can do!

ErinBecker commented 6 years ago

Thanks @tyson-swetnam and @lwasser for the conversation above. I'm elaborating a bit on the CAC discussion to see if I can help clarify the goals here.

The CAC had an in-depth discussion about the various options for both static and interactive plotting of geospatial data. The options that were considered for interactive plotting were leaflet and mapview. The relative benefits and downsides of these two packages were considered and the majority voted to use leaflet, as it is easier for learners to customize.

There is more detail about the CAC's discussions of these issues

here here and here

The decision at this point was to add a new episode to the raster-vector lesson for interactive plotting using leaflet, doing some customization but keeping the leaflet code as simple as possible.

ErinBecker commented 6 years ago

This won't be implemented before the first lesson release, currently scheduled for mid-July. I've added a status:wait label.

rbavery commented 4 years ago

Hi @ErinBecker just curious what the status of this is? I'll be teaching some geospatial R plotting and since most time is spent doing interactive analysis rather than publication quality static graphics I'd prefer to show folks first how to use mapview. If there's something already in the works for interactive mapping in R I would love to work off of that, if not no worries.

kerchner commented 4 years ago

We used this material before, and it worked well. Took about an hour:

https://hautahi.com/rmaps

I think the main issue here is that many learners would like to walk away knowing how to create a choropleth map, whether it's interactive, like with leaflet, or static. Leaflet is great, by the way, but it might be one step beyond simpler cholopleth mapping, in terms of a logical order of instruction.

jsta commented 4 years ago

I favor mapview for it's simplicity so my strategy during workshops is to continually encourage learners to view their output using mapview. My preference would be to include a tooltip pointing learners to mapview and reminder for instructors in the notes rather than writing standalone interactive plotting content.