datacite / omniauth-orcid

ORCID Strategy for OmniAuth
MIT License
9 stars 9 forks source link

Doubled SCRIPT_NAME when application is deployed to a sub-URI #18

Open speckins opened 8 months ago

speckins commented 8 months ago

I noticed when using the "orcid" strategy with a Rails application deployed to a sub-URI (e.g., www.example.com/sub-uri/), the script name is duplicated in the redirect_uri, (e.g., https://www.example.com/sub-uri/sub-uri/auth/orcid/callback). The definition of OmniAuth::Strategies::ORCID#callback_url includes script_name:

https://github.com/datacite/omniauth-orcid/blob/caf25d6940b8aaf31d31318e7259897120ca15f5/lib/omniauth/strategies/orcid.rb#L153-L155

But in OmniAuth::Strategy, #callback_path already includes script_name:

https://github.com/omniauth/omniauth/blob/d014c0e8af9ffa771f9f690d7313f46fdf5e94d0/lib/omniauth/strategy.rb#L445-L453

This was changed in https://github.com/omniauth/omniauth/commit/c606a00798a7f516c37c67a708864f9a3eb9f796.