datacite / omniauth-orcid

ORCID Strategy for OmniAuth
MIT License
9 stars 9 forks source link

Support omniauth-oauth2 1.4.0 #6

Closed yob closed 8 years ago

yob commented 8 years ago

I can see that in #1, this gem was changed to require omniauth-oauth2 1.3.1.

Since the breaking change in omniauth-oauth2 1.4.0 was released, it seems the omniauth-facebook and omniauth-google-oauth2 gems have released updates that continue to work.

The fix for omniauth-facebook looks like it wasn't too complicated - is there any chance the fix for this gem will be as simple?

mfenner commented 8 years ago

See pull request #7 by @eleanorakh that I just merged. Will do a new release with the changes soon, until then use the master branch.

yob commented 8 years ago

Thanks!

yob commented 8 years ago

Hi - just checking in on this. Are there any plans for a new release?

mfenner commented 8 years ago

omniauth-oauth2 1.4.0 is now supported in omniauth-orcid 1.2.x.