NFDI instrument main function - Githubissues

datacite / pidgraph-notebooks-python

MIT License

14 stars 9 forks source link

NFDI instrument main function #23

Closed bklaing2 closed 1 year ago

bklaing2 commented 1 year ago

Purpose

Notebook for NFDI

closes: Add github issue that originated this PR

Approach

use functions to encapsulate functionality

Open Questions and Pre-Merge TODOs

[ ] Error handling
[ ] altair display
[X] ids extractor
[X] main function
[X] input function
[X] Markdown Header

Learning

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kjgarza commented 1 year ago

LGTM