Use shared assets from assets.datacite.org

svogt0511 commented 1 year ago

Purpose

closes: schema#126 See the bug report.

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

KellyStathis commented 1 year ago

@svogt0511, I'm not sure why but I can't get this to work. The server starts, but when I access localhost in the browser this is the error message:

RuntimeError at /
Could not file /data/links.json
Ruby    /opt/homebrew/lib/ruby/gems/2.6.0/gems/borrower-0.10.0/lib/borrower/manifest.rb: in find, line 41
Web GET localhost/

Screen Shot 2023-05-15 at 14 43 01

Is there something else I need to do to access /data/links.json? I know this is hosted on the new assets server: https://assets.datacite.org/data/links.json - do I also need this locally somewhere?

svogt0511 commented 1 year ago

@KellyStathis - From the screenshot, it looks like it is looking in the wrong gemset. It should be looking in the project vendor/bundle. Did you (from the project directory):

cp .env.stage .env
bundle _1.17.3_ install
# make sure pandoc has been installed
bundle exec middleman server -e stage

links.json is used to generate header and footer links. For staging, it should live at https://assets.stage.datacite.org/data/links.json or production it lives at https://assets.datacite.org/data/links.json. You should not have to have it locally. Maybe when you tried it, that file wasn't in place at assets.datacite.org. Give it a try again.

I have done the builds locally (production/stage using 'middleman server' and production using 'middleman build' ) and have had no problem.

Pandoc may be problematic, but if I make sure it is installed, it works fine.

datacite / schema