search

datacommonsorg / website

Code for the Data Commons website
https://datacommons.org
Apache License 2.0
24 stars 88 forks source link

Added terraform variable google_analytics_tag_id for enabling Google Analytics #4572

Closed dwnoble closed 3 months ago

dwnoble commented 3 months ago
kmoscoe commented 3 months ago

Problem is the name of the variable in base.html is GA_ACCOUNT. Don't they need to be the same?

On Thu, Aug 22, 2024, 1:30 PM Dan Noble @.***> wrote:

@dwnoble https://github.com/dwnoble requested your review on: #4572 https://github.com/datacommonsorg/website/pull/4572 Added terraform variable google_analytics_tag_id for enabling Google Analytics.

— Reply to this email directly, view it on GitHub https://github.com/datacommonsorg/website/pull/4572#event-13983714202, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHMM7UAHAER2GCDCMX4HWL3ZSZDADAVCNFSM6AAAAABM64CH2OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE4DGNZRGQZDAMQ . You are receiving this because your review was requested.Message ID: @.***>

dwnoble commented 3 months ago

Problem is the name of the variable in base.html is GA_ACCOUNT. Don't they need to be the same?

@kmoscoe main.tf takes care of translating between google_analytics_tag_id and GA_ACCOUNT. Maybe in a follow up we can rename GA_ACCOUNT to GOOGLE_ANALYTICS_TAG_ID to be more precise

kmoscoe commented 3 months ago

Yes please! Let's add it to env.list | sample and rename it. I will prepare a doc PR for that.

dwnoble commented 3 months ago

Yes please! Let's add it to env.list | sample and rename it. I will prepare a doc PR for that.

Done, and renamed GA_ACCOUNT to GOOGLE_ANALYTICS_TAG_ID