Line numbers in error messages for compiled SQL are off

dataform-co / dataform

Dataform is a framework for managing SQL based data operations in BigQuery

https://cloud.google.com/dataform/docs

Apache License 2.0

854 stars 166 forks source link

Line numbers in error messages for compiled SQL are off #108

Closed lewish closed 4 years ago

lewish commented 5 years ago

This is due to how the SQL get's compiled.

A quick fix for this would be to:

[ ] Change the compiler code to not start any new lines before the actual query contents (this will break line 1's column numbers but that's less important and they are broken anyway)
[ ] Make sure when we extract JS blocks, we keep empty lines in their place

Moved from dataform-co/dataform-tracking#124 /cc @lewish

BenBirt commented 5 years ago

@emilywilson2 for updates

BenBirt commented 5 years ago

Some cleanup update:

Add line numbers to run-logs compiled queries
Next, let's highlight the relevant line(s) in compiled queries on the RHS sidebar
Longer-term, let's track back the line number to any JS where we can (at a lower priority though, this is hard, probably involves adding sourcemaps)

dwl285 commented 5 years ago

When we do this, we should a) highlight the line number the error is on, and b) default show the compiled query (5 lines before error + error line + 5 lines after error) if there is a compilation error