datajoint / datajoint-matlab

Relational data pipelines for the science lab
MIT License
42 stars 39 forks source link

master branch contains dangerous bugs #16

Closed FlorianFranzen closed 11 years ago

FlorianFranzen commented 11 years ago

Today I realized that the master branch still contains issue #4 which causes our users to delete almost all of the data from our database when removing even a single electrode array from our database.

There are a few more fixes that have never been merged into master.

Therefore I would recommend to update master to a newer version from future or some guidance what versions you guys think should be used for stable operation. I always thought master resembles the stable branch but that does not seem to be the case anymore.

There is also a bugfix branch but it has not seen an update for some time, so I guess it is not used by anyone either.

aecker commented 11 years ago

Yeah, I agree. I've been using future for ages and periodically we've added little things and fixed some issues. We should put out a new version soon.

dimitri-yatsenko commented 11 years ago

The only reason I haven't made the release is that I haven't tested issue #2 extensively: multiple datajoint schemas in the same database. Other than that, future has been stable for some time. It implements multiple important improvements and fixes. I think we can wait for ahoenselaar to finish adding the syntax for declaring additional indices and support for the Parallel Computing Toolbox. It looks like he is about to finish these features.

ahoenselaar commented 11 years ago

In the future, bugs of such impact should trigger a bugfix release to master. We could use a major.minor.bugfix versioning scheme for releases. A [major.minor] release will remain feature- and API-stable but receive important bugfixes. I am going to finish implementing secondary indexes and PCT support and put some effort into testing issue #2 . Then we should be ready for 2.6 (if we adopt the new versioning scheme) or 2.5.2 in the old scheme.

dimitri-yatsenko commented 11 years ago

Agreed. Let's release 2.6 in the next few days and adopt better practices going forward since now we have a larger user base. Henceforth, let's keep master updated with latest bug fixes; future will be used for new features to be included in the upcoming release.

dimitri-yatsenko commented 11 years ago

just released version 2.6 (tag v2.6). I have tested most features, but there have been quite a few recent changes, so let's test it extensively.