Fix: config-dev to config

datakaveri / dx-acl-apd

DX-ACL-APD

https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/datakaveri/dx-acl-apd/main/docs/openapi.yaml

Apache License 2.0

0 stars 10 forks source link

Fix: config-dev to config #160

Closed shreelakshmijoshi closed 2 months ago

shreelakshmijoshi commented 3 months ago

Updated config-dev.json to config.json. Link : https://github.com/datakaveri/iudx-gis-interface/pull/124#issuecomment-2219717761 Refactored :

Ideas contributed by @abhi4578

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

abhi4578 commented 3 months ago

Probably we can have folowing things in central repo,, as discussed during licensing strategy with Sanil in March

Code of conduct
Contribution guideline template, can have in each repo probably,
Release notes, strategy of each individual servers along with mission and rough roadmap.

in a centralized repo at https://github.com/datakaveri/iudx , maybe can be renamed to data for pubic good or so

Reference: https://github.com/sodafoundation/soda

@swaminathanvasanth

jenkins-datakaveri commented 3 months ago

Build finished.

shreelakshmijoshi commented 3 months ago

Even in the example configs directory, please rename the file to config.json from config-dev.json

Some configuration options that we can remove , which are not used. So that the config becomes more cleaner and easier to configure the server

"prodVhost": "<prod-vHost-name

Thanks for reviewing, added the changes in these commits : Refactor: config-dev to config, Refactor: redundant, unnecssary config

About removing host even though it might not be used in Deployer.java for production, it is being used in DeployerDev.java for non-clustered deployments like dev environments
https://github.com/datakaveri/iudx-acl-apd/blob/bfb8ac8e4486631239c5e8a8dbb3e3d82df9d199/src/main/java/iudx/apd/acl/server/deploy/DeployerDev.java#L39
I'm guessing both clustered and non-clustered deployments use a single config, please do correct me if I'm wrong

jenkins-datakaveri commented 3 months ago

Build finished.

abhi4578 commented 3 months ago

* About removing `host` even though it might not be used in Deployer.java for production, it is being used in `DeployerDev.java` for non-clustered deployments like dev environments

* https://github.com/datakaveri/iudx-acl-apd/blob/bfb8ac8e4486631239c5e8a8dbb3e3d82df9d199/src/main/java/iudx/apd/acl/server/deploy/DeployerDev.java#L39

* I'm guessing both clustered and non-clustered deployments use a single config, please do correct me if I'm wrong

Even in deployerDev its not being used anywhere finally, following line can be removed. https://github.com/datakaveri/iudx-acl-apd/blob/bfb8ac8e4486631239c5e8a8dbb3e3d82df9d199/src/main/java/iudx/apd/acl/server/deploy/DeployerDev.java#L39 Ref: https://github.com/search?q=repo%3Adatakaveri%2Fiudx-acl-apd+host&type=code&p=2
- Also we can club DeployerDev.java and Deployer.java. Will create an feature issue of the same

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

shreelakshmijoshi commented 3 months ago

retest this please

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 3 months ago

Build finished.

jenkins-datakaveri commented 2 months ago

Build finished.