datakurre / collective.pfg.dexterity

Dexterity PFG Adapter
2 stars 3 forks source link

Make compatible with P5 #13

Closed 3dogMcNeill closed 8 years ago

3dogMcNeill commented 8 years ago

Have a use case for this in P5 site. Can confirm it doesn't work with Plone 5.0. For buildout, need to upgrade pin version for archetypes.referencebrowserwidget. Also had to add this to eggs: "plone.app.contenttypes [atrefs]"

After buildout, addon seems to install with no problems. But in PFG form folder, adding a Content Adapter throwsAttributeError: 'referencebrowser.js' Also had various other AttributeError: 'NoneType' object has no attribute 'portal_type' errors.

tkimnguyen commented 8 years ago

please paste here the full error stack!

3dogMcNeill commented 8 years ago

There are multiple errors. It needs to be reworked/rechecked from top to bottom. Also, there aren't directions for installing on P5... so maybe this "plone.app.contenttypes [atrefs]" is part of what's mucking things up, I don't know. I'm just reporting that it doesn't work with P5 and that it's not because of only one error. Somebody with far more experience can dive in and see what's really going on.

datakurre commented 8 years ago

I can confirm that I haven't used this on P5 and may not be very soon. I'll move this to collective once I'm back to work (early July) and I can give PYPI rights to anyone who is willing to maintain.

Otherwise the "magic" in this package should still work on P5 in principle.

On 24. kesäkuuta 2016 klo 18.40 +0300, Christina M.notifications@github.com, wrote:

There are multiple errors. It needs to be reworked/rechecked from top to bottom.

— You are receiving this because you are subscribed to this thread. Reply to this email directly,view it on GitHub(https://github.com/datakurre/collective.pfg.dexterity/issues/13#issuecomment-228379916), ormute the thread(https://github.com/notifications/unsubscribe/AAJyv98giSnwuEU0mjSCCRt8rwnrzIRzks5qO_pXgaJpZM4I92r2).

tkimnguyen commented 8 years ago

Thanks Asko. On pypi it seems easiest to grant rights to 'collective'.

On Fri, Jun 24, 2016 at 4:04 PM, Asko Soukka notifications@github.com wrote:

I can confirm that I haven't used this on P5 and may not be very soon. I'll move this to collective once I'm back to work (early July) and I can give PYPI rights to anyone who is willing to maintain.

Otherwise the "magic" in this package should still work on P5 in principle.

On 24. kesäkuuta 2016 klo 18.40 +0300, Christina M.< notifications@github.com>, wrote:

There are multiple errors. It needs to be reworked/rechecked from top to bottom.

— You are receiving this because you are subscribed to this thread. Reply to this email directly,view it on GitHub( https://github.com/datakurre/collective.pfg.dexterity/issues/13#issuecomment-228379916), ormute the thread( https://github.com/notifications/unsubscribe/AAJyv98giSnwuEU0mjSCCRt8rwnrzIRzks5qO_pXgaJpZM4I92r2 ).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/datakurre/collective.pfg.dexterity/issues/13#issuecomment-228461565, or mute the thread https://github.com/notifications/unsubscribe/AAxxOn61kAK6yeGI5pRVJ_EM_HLDZOAEks5qPEZHgaJpZM4I92r2 .

datakurre commented 8 years ago

I've added collective as owner at PyPI. It seems that I've already forked this repo to collective, so I cannot simply move this repo to collective (because I cannot remove the fork).

3dogMcNeill commented 8 years ago

For anybody who's willing to work on it, there's some discussion about it on the plone forums.

datakurre commented 8 years ago

I'm working on this now, and have fixed the compatibility issues with Plone 5. Once I get my cleanup finished and tests running again, I do a 1.0 release supporting both Plone 4.3 and Plone 5.0.

datakurre commented 8 years ago

I'm now working to add support for Plone 5. All main issues solved and just clean up, testing, etc to do.

datakurre commented 8 years ago

I've now released 1.0.0rc1, which should support both Plone 4 and Plone 5.

3dogMcNeill commented 8 years ago

Awesome, Asko, thanks!