Tweak git version spoofing in docker config, and test it

datalab-org / datalab

datalab is a place to store experimental data and the connections between them.

https://docs.datalab-org.io

MIT License

49 stars 17 forks source link

Tweak git version spoofing in docker config, and test it #1006

Closed ml-evs closed 2 weeks ago

ml-evs commented 2 weeks ago

Remove annoying warning by removing default value for spoof version in docker-compose
Add version spoof to CI to check that it does not introduce build failure

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.49%. Comparing base (5dc4e2c) to head (8e761e0). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1006 +/- ## ======================================= Coverage 68.49% 68.49% ======================================= Files 62 62 Lines 3955 3955 ======================================= Hits 2709 2709 Misses 1246 1246 ```

cypress[bot] commented 2 weeks ago

datalab Run #2778

Run Properties: Passed #2778 • 10e00635df ℹ️: Merge 8e761e00036f9d9054ee5b953e31902d5c74a734 into 5dc4e2c04f752e6674c9afdcfcbc...

Project	`datalab`
Branch Review	`ml-evs/test-spoofed-version`
Run status	`Passed #2778`
Run duration	`06m 11s`
Commit	`10e00635df ℹ️: Merge 8e761e00036f9d9054ee5b953e31902d5c74a734 into 5dc4e2c04f752e6674c9afdcfcbc...`
Committer	`Matthew Evans`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`405`
View all changes introduced in this branch ↗︎

ml-evs commented 2 weeks ago

This is very minor, don't think it kills our docker caching in CI (though impossible to say -- no performance decrease anyway) -- will merge