search

datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
49 stars 17 forks source link

Naively update eslint and plugins, remove some more vue-cli-plugins #988

Closed ml-evs closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.43%. Comparing base (fc2cf1b) to head (580fc86). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #988 +/- ## ======================================= Coverage 68.43% 68.43% ======================================= Files 62 62 Lines 3935 3935 ======================================= Hits 2693 2693 Misses 1242 1242 ```
cypress[bot] commented 3 weeks ago

datalab    Run #2717

Run Properties:  status check passed Passed #2717  •  git commit 5ce5d8d0a1 ℹ️: Merge 0933cb6302c725249ea2df1f9137043ea7b05825 into fc2cf1bd6bde51354be1614c4d6f...
Project datalab
Branch Review ml-evs/eslint
Run status status check passed Passed #2717
Run duration 06m 17s
Commit git commit 5ce5d8d0a1 ℹ️: Merge 0933cb6302c725249ea2df1f9137043ea7b05825 into fc2cf1bd6bde51354be1614c4d6f...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎
ml-evs commented 3 weeks ago

Putting this on hold as this is non-trivial for stupid JS ecosystem reasons. The eslint config file format has completely changed and they haven't released a migration script that works for us yet (https://eslint.org/docs/latest/use/configure/migration-guide). I'm tempted to bin all of our JS linting and start again with vite or likewise at some point.