datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
49 stars 17 forks source link

Revert overly smart schedule for upgrade PRs #999

Closed ml-evs closed 2 weeks ago

ml-evs commented 2 weeks ago

GitHub Actions schedules convert day (month) && day (week) clauses in cron jobs as OR, so we were just running every day of the week. This PR goes back to the simple case where both upgrade PRs run on a Wednesday. We can always just close the PR one week if we don't want to deal with it.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.38%. Comparing base (d381512) to head (e15fce8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #999 +/- ## ======================================= Coverage 68.38% 68.38% ======================================= Files 62 62 Lines 3941 3941 ======================================= Hits 2695 2695 Misses 1246 1246 ```
ml-evs commented 2 weeks ago

Will merge this myself, as otherwise we'll get an extra PR generated per day before this is merged.

cypress[bot] commented 2 weeks ago

datalab    Run #2749

Run Properties:  status check passed Passed #2749  •  git commit 8cd060b396 ℹ️: Merge e15fce8a5f0201b047096623ae27ef2148b174cb into d381512692475711a5dae5cf773f...
Project datalab
Branch Review ml-evs/fix-ci-schedule
Run status status check passed Passed #2749
Run duration 05m 19s
Commit git commit 8cd060b396 ℹ️: Merge e15fce8a5f0201b047096623ae27ef2148b174cb into d381512692475711a5dae5cf773f...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 135
View all changes introduced in this branch ↗︎