datamade / chi-councilmatic

:eyes: keep tabs on Chicago city council
https://chicago.councilmatic.org/
MIT License
21 stars 16 forks source link

remove django-councilmatic as a dependency. #361

Closed fgregg closed 8 months ago

fgregg commented 11 months ago

experience has taught us that the pattern where we have base templates, views, and models in one repo, which we we subtype and override in this project creates a lot of friction without benefits.

not only does that produce confusing indirection, changes to django-councilmatic have to be made slowly and carefully to not impinge on la-metro

i propose that we remove django-councilmatic as a dependency for chi-councilmatic.

here's what would be needed

we've already localized all the templates. and it won't be too hard to localize the views as we have largely duplicated all of them anyway.

localizing the models will be the most challenging piece as we need to provide hooks so that when chicago-council-scrapers run it will update the right models.

we could do that by making the chi-councilmatic models an installable app as python-opencivicdata does.

fgregg commented 11 months ago

if we made the python-opencivicdata models more fit for purpose for a web app, this would make things a lot simpler.

https://github.com/opencivicdata/python-opencivicdata/issues/150

derekeder commented 11 months ago

+1

lets do it!

fgregg commented 11 months ago

removing views here: https://github.com/datamade/chi-councilmatic/pull/368