datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Bar plot maintenance #596

Open dv-usama-ansari opened 4 weeks ago

dv-usama-ansari commented 4 weeks ago

Coming from #563

Please see comments for more details

dv-usama-ansari commented 4 weeks ago

https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404849744

Spacing between axis label and ticks

563-axis-label-spacing

dv-usama-ansari commented 4 weeks ago

https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404861586

Clipped tooltip for very wide graph

image

dv-usama-ansari commented 4 weeks ago

https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404879739

Missing legend

image

dv-usama-ansari commented 4 weeks ago

https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2435125738

Bar plot for a group column containing all null values for this session:

Image

Discussion with @thinkh: We should show #71787E Unknown item in the legend and the tooltip

dv-usama-ansari commented 4 weeks ago

https://github.com/datavisyn/visyn_core/pull/598#issuecomment-2436224037

When all the values of an aggregation are 0 (not null or undefined), the bar chart does not show up since it cannot plot bars with 0 width. This happens for the following combination of configuration:

image

Me and @thinkh discussed came to a conclusion that there is unfortunately no way to show a bar with zero width. We should show a message to the user in such a case and prompt him/her to change the aggregation type or column selected

dv-usama-ansari commented 4 weeks ago

Comments with @thinkh following the discussion of https://github.com/datavisyn/visyn_core/issues/596#issuecomment-2437374594:

-Survival months filters out the 0 for all the aggregation.

-Tumor size has null across all categories of breast surgery type

dv-usama-ansari commented 3 weeks ago

Show a tooltip on the axis label for a bar plot like this:

Image

Will be addressed in #599

cc: @dvdanielamoitzi

dv-usama-ansari commented 3 weeks ago

Selection is lost when bar chart is sorted

https://github.com/datavisyn/visyn_core/issues/600

dv-usama-ansari commented 3 weeks ago

Incorrect name of the axis on initial load:

Image

This happens when https://github.com/datavisyn/reprovisyn/blob/d3b341252dd29ec17fd0960f0cec7a015084577b/reprovisyn/data/test_db2.json#L464-L465 is null

Will be addressed in #607

dv-usama-ansari commented 2 weeks ago

This issue would be open for continuous feedback

dv-usama-ansari commented 18 hours ago

Focus facet selector does not work as expected

https://github.com/user-attachments/assets/2de740ce-faa9-45cf-ae8f-91030d355b98