fix(vis-type: bar): selection is lost when bar plot is sorted - Githubissues

datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

fix(vis-type: bar): selection is lost when bar plot is sorted #604

Closed dv-usama-ansari closed 1 month ago

dv-usama-ansari commented 1 month ago

Closes #600

Developer Checklist (Definition of Done)

Issue

[x] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[x] Requires UI/UX/Vis review
- [x] Reviewer(s) are notified @thinkh @dvdanielamoitzi
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Fixed retaining selection when sort order is changed.

Screenshots

sort-selection-retain.webm

Additional notes for the reviewer(s)

It is necessary to use fine grained pre-conditions for the chart event listeners to dodge issues like these.

dvdanielamoitzi commented 1 month ago

Thanks for the quick fix @dv-usama-ansari ! I have tested it and it works well for me :100: