search

datenschuft / SMA-EM

SMA Energymeter measurement
GNU General Public License v2.0
92 stars 38 forks source link

check len of emparts before processing #77

Open mslacken opened 1 year ago

mslacken commented 1 year ago

close #70

littleyoda commented 1 year ago

I would suggest parsing the protocol id and then pick only packages with measured values

see my PR for SMA-EM https://github.com/kellerza/hassio-sma-em/pull/28

mslacken commented 1 year ago

As sma-em-measurements.py is just used for a quick check for what is going on in the network, it makes no difference how I ignore the stuff going on in the network.

littleyoda commented 1 year ago

At this point I would like to disagree. These types of scripts are often taken as a basis by other people. And so it would be good if a good solution were used directly and not a quick hack.

Let's see what the maintainer's opinion is.

dervomsee commented 1 year ago

@datenschuft Is the project still maintained? For me this commit fixes the issue.