search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
4 stars 5 forks source link

Create python-app.yml #41

Closed timsainb closed 5 months ago

timsainb commented 6 months ago

run pytest on PRs to see if anything is breaking

jonahpearl commented 6 months ago

Nice, thanks for adding this. Won't replace testing on a rig but should at least be able to run the core tests

jonahpearl commented 6 months ago

Looks like the pip install step failed after trying to install pyk4a — makes sense, since pyk4a requires the SDK toolkit. We can either 1) make pyk4a an optional dependency (seems like a good idea anyways for facilitating installs on dev computers / O2 / etc.), or 2) figure out how to put the SDK onto whatever these tests are running on, which imo sounds much harder.

jonahpearl commented 5 months ago

Ok, after some fiddling, the tests are running. We aren't installing PyNvCodec here so those tests still have to be run on a rig. (This looks possible based on their own CI but it's complicated / involves Docker and I don't have time or energy rn.) Obviously the microcontroller tests also have to run on a rig so it's no more of an annoyance to run the pynvcodec ones too.

jonahpearl commented 5 months ago

Also: I am deprecating requirements.txt for now because it's redundant with setup.cfg for most use cases. If we need specific requirements for dev / docs / etc, we can make separate requirements files.