search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
4 stars 5 forks source link

fixed live visualization #44

Closed calebweinreb closed 4 months ago

calebweinreb commented 5 months ago

There was a bug in the implementation of live vis in main. The image fetcher returned [None] when the queue was empty, an empty tuple when it was finished, and an image otherwise. The recipient code checked if len(data)>0 and if so, it indexed into data[0]. That resulted in only the first row of the image being displayed. In this PR, I now have the image fetcher return None when the queue is empty, and the recipient code processes each case correctly.

jonahpearl commented 4 months ago

That resulted in only the first row of the image being displayed.

Surely we would've noticed this? Was this only happening in some specific subset of instances?

calebweinreb commented 4 months ago

I don't know the vis just didn't work when I tried to use the pipeline out of the box. Does it work for you?