search

daumling / ireal-renderer

A HTML5/ES6 implementation of a renderer for iReal Pro playlists
MIT License
20 stars 5 forks source link

Improve descrambling and fix some rendering #4

Closed softins closed 4 years ago

softins commented 4 years ago

This PR provides two improvements:

  1. Simplifies the unscrambling loop, and also performs the substitutions for Kcl, LZ and XyQ in the reading, rather than the rendering, as they are just part of the scrambling, not the song representation.
  2. Adds alt and p to the chord regex. The alt is required by tunes such as A Child is Born, which has a D7alt, and p is used in many tunes to indicate a beat with a /
TerrapinSoftware commented 4 years ago

Thank you for your contribution! Merged successfully.