search

daveyholler / eui

Elastic UI Framework 🙌
https://elastic.github.io/eui/
Other
0 stars 1 forks source link

wip a11y example #6

Closed myasonik closed 5 years ago

myasonik commented 5 years ago

I didn't run tests on this but I ran through VoiceOver on this and I think this is the final state we're looking for.

Because of all the @ts-ignore I'm not sure if this is prod ready but I wasn't able to resolve them after a bit of tinkering. Maybe someone with some more TS skills on the EUI team can help resolve the issues?

I tried to leave a bunch of comments in this PR to make it clear what I'm doing and why. If anything isn't clear, let me know and I'm happy to jump on a call to resolve them quickly.

chandlerprall commented 5 years ago

@myasonik I'm unable to push directly to your branch, so here's a PR cleaning up the typescript and isNesting stuff https://github.com/myasonik/eui/pull/1

myasonik commented 5 years ago

@daveyholler I guess you can just merge this now?

One thing left to add that I think got lost somewhere is i18n for all strings (the instructions and the aria-label I think are it).