search

daveyliam / mapwriter

MapWriter: A minimap mod for Minecraft
MIT License
89 stars 81 forks source link

Fix ArrayOutOfIndex exception when in underground mode #11

Closed tterrag1098 closed 10 years ago

tterrag1098 commented 10 years ago

That should do it, right? Worked in my dev environment

daveyliam commented 10 years ago

Thanks for finding the bug!

Your fix works, but instead of checking the Y value on every getBlockAndMeta call, I think I will just make sure that startY is greater or equal to 0 in ChunkRender.renderUnderground. This way the check is only done once per chunk rather than hundreds of times per chunk.

tterrag1098 commented 10 years ago

Oh, that works, yeah. Didn't think of that. I was having some issues getting the project working so I did the first fix I thought of.

tterrag1098 commented 10 years ago

Also, when can we expect the next build with this in it?

daveyliam commented 10 years ago

I should be able to make a release tomorrow. Not enough time left of tonight to finish off what i've been working on (texture support) and post a new version.