daveyliam / mapwriter

MapWriter: A minimap mod for Minecraft
MIT License
89 stars 81 forks source link

MP data storage path #44

Open xarses opened 9 years ago

xarses commented 9 years ago

In MP sessions the data storage path is constructed from the result of a resolve or host command on the host part and port of the server instead of the users entered name on the server. This results in the map data being lost should the user need to update the host, port or in the case that the resolved value of host changes. This results in in-ability to access the map data until the folder is renamed on the filesystem.

Vectron commented 9 years ago

we have multiple problems here.

case 1: person uses direct conect to connect to a server, this means the IP+port will be the save directory. person wants to play more often on this server and thus adds it to the list with a name. not the save is server name + port. and all data is "lost"

case 2: person adds a server then the save will be name+port, the person changes the name/port for whatever reason and again all data is lost.

case 3: data gets saved as ip+port one of them changes and again all data is lost.

the problem is that it doesnt realy matter how you save it, if anything changes the data gets "lost". as a result we treat it as a new server if anything changes.

(as a side not i dont think any of these values change that often so most people dont have the problem)