Closed PepijnBoers closed 2 years ago
@PepijnBoers didn't you finish yet? Or was closing it a mistake?
@davidberenstein1957 I was creating the feature for personal use and accidentally created the PR on your repo istd of my fork. But if you'd be interested in supporting multi-label classification in the main repo, I could make an actual PR. Let me know!
Yes please do!
On Tue, May 24, 2022 at 11:07 AM Pepijn Boers @.***> wrote:
@davidberenstein1957 https://github.com/davidberenstein1957 I was creating the feature for personal use and accidentally created the PR on your repo istd of my fork. But if you'd be interested in supporting multi-label classification in the main repo, I could make an actual PR. Let me know!
— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1135613112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZA5ZY6VRS6P73IGFUDVLSL5BANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>
Ok, I'll probably work on it this week.
@PepijnBoers could you take a look at the formatting standards? Also, please provide some tests, and context/example in the readme.
@davidberenstein1957 ready for review.
@davidberenstein1957 ready for review.
What is the status on this?
Hey Pepijn,
Sorry. I haven't really worked on my packages that much due to some busy months. I'll work on it during the coming weeks.
Regards, David
On Mon, Sep 12, 2022 at 10:06 AM Pepijn Boers @.***> wrote:
@davidberenstein1957 https://github.com/davidberenstein1957 ready for review.
What is the status on this?
— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1243364352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZBQQZH3WSLJS3BLNXLV53QA3ANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>
Awesome! please take a look at my formatting preferences.
On Tue, May 24, 2022 at 11:26 AM Pepijn Boers @.***> wrote:
Ok, I'll probably work on it this week.
— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1135642695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZF55BXLIU7U7T2X543VLSOCXANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>
Hey, any updates on this? When is this going to be integrated?
@PepijnBoers I took a while from my side, but thanks a lot for your contribution! I will fine-tune this today and add it to the next release.
@PepijnBoers you can take a look at my initial refactoring. I expect to be able to wrap up the entire release coming Friday.
@miroslavtushev See the comment above.
Extends the Spacy classy skeleton to support multi-label classification, using a multi-layer perceptron.