search

davidcarlisle / dpctex

Assorted TeX packages
93 stars 30 forks source link

Incomplete longtable patch #4

Open aoles opened 7 years ago

aoles commented 7 years ago

Dear David,

first of all thank you for your work on all these useful LaTeX packages! While reviewing the changes to longtable.sty I've noticed some inconsistency compared to the original patch. I believe that the line

\ifLT@ivcompat\global\vsize\@colroom\fi

should rather be

\ifLT@ivcompat\else\global\vsize\@colroom\fi

Cheers, Andrzej

davidcarlisle commented 7 years ago

Ah, thanks it does look that way, thanks for leaving the issue here, I'll try to find some time to work on LT ....

On 9 December 2016 at 11:38, Andrzej Oleś notifications@github.com wrote:

Dear David,

first of all thank you for your work on all these useful LaTeX packages! While reviewing the changes to longtable.sty I've noticed some inconsistency compared to the original patch http://www.latex-project.org/cgi-bin/ltxbugs2html?pr=tools/3512. I believe that the line https://github.com/davidcarlisle/dpctex/blob/44224bcc2b091de966194fc32c1a91251523de5e/longtable/longtable.dtx#L2036

\ifLT@ivcompat\global\vsize\@colroom\fi

should rather be

\ifLT@ivcompat\else\global\vsize\@colroom\fi

Cheers, Andrzej

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/davidcarlisle/dpctex/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNcAsJwPbCyt1S-cFi0xSMcE-1wYYtqks5rGT3GgaJpZM4LI2WQ .