search

davidebbo / WebActivator

Apache License 2.0
242 stars 49 forks source link

See issue #6 discussion. #7

Closed gdoten closed 11 years ago

gdoten commented 11 years ago

Some changes per our discussion here: https://github.com/davidebbo/WebActivator/issues/6

davidebbo commented 11 years ago

Please make sure to use spaces instead of tab. You can do an amend / force push to keep history clean. Thanks!

gdoten commented 11 years ago

Think I've got that to work via an amend. Take a look.

davidebbo commented 11 years ago

Does look like you did an amend/force, as you now have 3 commits instead of one :)

gdoten commented 11 years ago

Is that good or bad?

davidebbo commented 11 years ago

Sorry, I meant 'doesn't' look like. I can just make the change if you like if you don't trust your git skillz here :) But you won't have your name on the commit :(

gdoten commented 11 years ago

Indeed, I am entrenched in Hg. If I do a pull of my repo Git tells me I am up to date and I see the nice little bullets instead of tabs. If what's out there now doesn't work for you then please do go ahead and make the edits.

davidebbo commented 11 years ago

Ok, done deal! New build is on NuGet as version 1.5.3.