search

davidfowl / AspNetCoreDiagnosticScenarios

This repository has examples of broken patterns in ASP.NET Core applications
7.92k stars 750 forks source link

Typo in HttpClientGuidance.md #74

Closed eisenpony closed 3 years ago

eisenpony commented 3 years ago

The note about WebClient contains some contradictory advice.

WebClient is considered a legacy .NET API at this point and has been completely superseded by HttpClient. No new code should be written with HttpClient.

Seems to suggest HttpClient should both:

  1. be used instead of WebClient
  2. never be used
udlose commented 3 years ago

there is already a PR for this typo. Just hasn't been merged yet - https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/pull/71

eisenpony commented 3 years ago

Thanks. Still learning github 😅