prefer popup over preview window

davidhalter / jedi-vim

Using the jedi autocompletion library for VIM.

MIT License

5.27k stars 370 forks source link

prefer popup over preview window #1093

Closed Konfekt closed 1 year ago

Konfekt commented 1 year ago

addresses #1092

davidhalter commented 1 year ago

I like the changes a lot, I'm just unsure why you changed that one specific thing.

davidhalter commented 1 year ago

The coverage tests are currently failing, I feel like this is something unrelated. Maybe @blueyed has any idea? I feel like if he does not chime in I might disable the coverage tests temporarily.

davidhalter commented 1 year ago

Sorry forgot to merge, because I spilled tea on my notebook and it took me a while to get it back in good shape. Now that I have it back, I found the tab of this PR again. Thanks a lot again :)