davidhalter / jedi-vim

Using the jedi autocompletion library for VIM.
MIT License
5.27k stars 370 forks source link

Open the pydoc documentation in a new tab #1098

Closed jamescherti closed 1 year ago

jamescherti commented 1 year ago

This pull request adds a feature that allows opening the pydoc documentation in a new tab when the user presses the K key.

It also adds a new option to choose how Jedi-vim opens the documentation:

Option: g:jedi#way_to_open_documentation (The buffer-local version: b:jedi_way_to_open_documentation)

Option values:

Default value: split (Same as before)

davidhalter commented 1 year ago

I do not think this is currently a good idea to add. The maintenance burden on stuff like this is just too big and I doubt a lot of people will use it (Most people do not read the docs anyway). But since jedi-vim isn't changing a lot, I feel like you can safely maintain a fork and just merge all newer changes.

Still thanks a lot for contributing.

jamescherti commented 1 year ago

Thank you for taking the time to review the code, @davidhalter .

I have created the Vim plugin vim-jedipydoc that allows opening the Pydoc/Python documentation in a new tab (By default) or in a new horizontal split.

davidhalter commented 1 year ago

That sounds like a great solution, thanks!