Closed RayBB closed 7 months ago
Related question, do you know how many rows your current setup is using? Depending on how vaultwarden works I could see 10k rows (the Heroku Postgres limit) being hit faster than the 5MB limit of JawsDB.
About 1500-1600 rows, give or take. About 1500 in passwords (a lot of carry-over from nearly a decade in Google Passwords that haven't been purged).
@RayBB - Do you know if the Heroku Postgres database requires Heroku to be verified? I don't currently have a test-bed for this, so hopefully, you know offhand. Just want to prevent someone from adding it and not realizing it requires a verified account.
Other than that LGTM. Thanks for the PR and the newline. Once I hear back, I'll get it merged!
@davidjameshowell According to this SO from 2020, you don't need to be verified for the postgres addon but I can't say for sure if it's still that way. https://stackoverflow.com/a/61298202/620699
Just wanted to make it easier to use
USE_PSQL
.Feel free to edit the copy or whatever about this PR that you'd like to before squash/merging.
PS: I didn't add a blank line to the bottom of
.github/workflows/deploy.yml
- GitHub web editor did it automatically and won't let me remove it.Related question, do you know how many rows your current setup is using? Depending on how vaultwarden works I could see 10k rows (the Heroku Postgres limit) being hit faster than the 5MB limit of JawsDB.
PS: For anyone looking in the future, you might consider the free tiers of PlanetScale (5 GB storage, 1 billion row reads/mo) for Fly.io PostGres (3 GB), both of which require Credit Cards. They both seem like better choices but I don't have time to set them up now.
Thanks so much for maintaining this awesome little tool @davidjameshowell