Closed K265 closed 3 years ago
My only concern is when using secret values, as I have found out, the logs for any of those actions will truncate/obscure the value it is derived. In this case, the value 1 or 0 will show up as "*" instead throughout the entire log.
If you want to remove and create a PR for the README to appropriately list where that update would be made, I would accept that.
The app name fix is fine and if you want to split these, that's OK with me too.
Let me know what you think of that proposal.
I see your point I'm going to split the commits Thank you :-)
My only concern is when using secret values, as I have found out, the logs for any of those actions will truncate/obscure the value it is derived. In this case, the value 1 or 0 will show up as "*" instead throughout the entire log.
If you want to remove and create a PR for the README to appropriately list where that update would be made, I would accept that.
The app name fix is fine and if you want to split these, that's OK with me too.
Let me know what you think of that proposal.