search

davidnguyen11 / create-react-progressive-web-app

Simple demo of progressive web app. This demo will display the news of technology from API provided by https://newsapi.org/
60 stars 10 forks source link

Home Banner #2

Closed edouardbrasier closed 7 years ago

edouardbrasier commented 7 years ago

Does the home banner works for you? I have tried to host jeffposnick/create-react-pwa demo with firebase but there is no home banner installation on my android.

davidnguyen11 commented 7 years ago

I have just tested it. Look likes it only works in Chrome on Android.

edouardbrasier commented 7 years ago

Yes this is only supported by chrome.

What I meant is that it works with the original react pwa demo link provided by Jeff as it adds a banner on my phone. However when I recreated with "git clone" the code is working except the banner. I get no error it just never installs the banner.

I am curious to see if you have the same issue. Can you provide a url link of your demo?

I can tell you if it adds the banner or not.

Cheers

On 3 Feb 2017 3:20 a.m., "David Nguyen" notifications@github.com wrote:

I have just tested it. Look likes it only works in Chrome on Android.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nndung179/create-react-pwa-demo/issues/2#issuecomment-277154745, or mute the thread https://github.com/notifications/unsubscribe-auth/AS4njjcK8zXr8tMf8fJIcCHtuenO00MXks5rYpz8gaJpZM4L1lfQ .

edouardbrasier commented 7 years ago

Well you might want to ignore thus issue because it looks like my own demo is now working and installed a home banner on my phone. I wonder why it didn't work the previous day. Perhaps the short name in the manifest was too long.

On 3 Feb 2017 7:41 a.m., "Edouard Brasier" edouardbrasier@gmail.com wrote:

Yes this is only supported by chrome.

What I meant is that it works with the original react pwa demo link provided by Jeff as it adds a banner on my phone. However when I recreated with "git clone" the code is working except the banner. I get no error it just never installs the banner.

I am curious to see if you have the same issue. Can you provide a url link of your demo?

I can tell you if it adds the banner or not.

Cheers

On 3 Feb 2017 3:20 a.m., "David Nguyen" notifications@github.com wrote:

I have just tested it. Look likes it only works in Chrome on Android.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nndung179/create-react-pwa-demo/issues/2#issuecomment-277154745, or mute the thread https://github.com/notifications/unsubscribe-auth/AS4njjcK8zXr8tMf8fJIcCHtuenO00MXks5rYpz8gaJpZM4L1lfQ .

davidnguyen11 commented 7 years ago

@edouardbrasier I find something I think it is gonna be useful

http://blog.teamtreehouse.com/optimizing-mobile-web-apps-ios