search

davidortinau / Xappy

A mobile app to track Xamarin news and explore all the goodness that is .NET for Mobile developers
MIT License
350 stars 106 forks source link

Rebuild LoginPage using CSharpForMarkup #30

Closed VincentH-Net closed 5 years ago

VincentH-Net commented 5 years ago

LoginPage built using CSharpForMarkup 1) @rdavisau build initial version live on Twitch, cleanup afterwards 2) @VincentH-Net cleanup & separate markup, animation logic and DSL. Add hyperlink using new CSharpForMarkup Span helpers

VincentH-Net commented 5 years ago

@rdavisau I noticed csproj changes LangVersion + MtouchExtraArgs. Should those be in here or is that only for Continuous? You OK with the rest of my changes?

rdavisau commented 5 years ago

It's a thing of beauty! 👀

I needed to set LangVersion to use CSharpForMarkup with VS4Mac (maybe VS4Mac defaults to a lower version?). --enable-repl is harmless but definitely not required (I should have removed it in 604fac8).

Nice work!

VincentH-Net commented 5 years ago

Thanks @rdavisau! I removed all unneeded changes from sln and csproj files and tested against latest stable VS Win and VS Mac.

I only needed to set language version to latest in the shared project to fix build in VS for Mac; VS doc says

The C# compiler determines a default language version ... When your project doesn't target a preview framework, the language version used is the latest minor version.

However, apparently VS for Mac defaults to latest major. Setting the language to latest ensures the same behaviour in VS Win and VS Mac.