search

davidrapan / ha-solarman

⚡ Solarman Stick Logger integration for 🏠 Home Assistant
MIT License
110 stars 25 forks source link

bugfix: revert name on KSTAR Battery type #118

Closed frsantos closed 2 months ago

frsantos commented 2 months ago

This register holds the battery type according to the documentation, not the control mode.

It was changed some time ago when renaming a bunch of other sensors.

frsantos commented 2 months ago

Hi @davidrapan, any chance we can merge this?

davidrapan commented 2 months ago

Hey @frsantos I totally forgot about the PR's here, sorry bout that.

Just to be clear, did I mistake this entity with "Control Mode" entity from for example sg01hp3 profile? Where is it a R/W value?

frsantos commented 2 months ago

Hey @frsantos I totally forgot about the PR's here, sorry bout that.

Just to be clear, did I mistake this entity with "Control Mode" entity from for example sg01hp3 profile? Where is it a R/W value?

Not sure why this was changed. This happened in commit https://github.com/davidrapan/ha-solarman/commit/bb2cf5ed2865345e867402f9a202405cbe8b52b0#diff-a7d9ca118f75f1e89c940355d141f0c1060b6320ff7ca9b17d416a28c5bb1f69R302. The KSTAR register is listed in the 3.1. Inverter basic information（04H Read) section, so it's not a R/W register (function 04H/06H), just a read register (function 04H).