search

davidstrauss / google-drive-recursive-ownership

Tool to recursively give away file and document ownership to another user.
MIT License
268 stars 68 forks source link

Repository contains an example key that end-users should replace #24

Closed mex20 closed 5 years ago

mex20 commented 5 years ago

I would suggest using a dummy JSON file for the client_secrets.json instead of an actual client. I just followed the directions to run an example execution of this program, and it seems like it is attempting to use a real key. The key had 2FA, so that is good. However a dummy file should be put in it's place.

davidstrauss commented 5 years ago

There's no actual private data in the repository. The key file is from a Google example project. So, in a sense, it is a dummy file.

There's also no concept of 2FA for the keys, AFAIK. What you're seeing is the OAuth 2.0 flow to authorize the example key to access your account, which is a bad idea.

I'd be happy to take a pull request to update the instructions to tell people to actually obtain and use their own key. Otherwise, they're authorizing the example credentials to access their data.

mex20 commented 5 years ago

That's great! We can totally close this issue out then.

On Wed, Oct 24, 2018, 4:06 PM David Strauss notifications@github.com wrote:

There's no actual private data in the repository. The key file is from a Google example project https://github.com/gsuitedevs/python-samples/blob/master/drive/driveapp/client_secrets.json. So, in a sense, it is a dummy file.

There's also no concept of 2FA for the keys, AFAIK. What you're seeing is the OAuth 2.0 flow to authorize the example key to access your account, which is a bad idea.

I'd be happy to take a pull request to update the instructions to tell people to actually obtain and use their own key. Otherwise, they're authorizing the example credentials to access their data.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davidstrauss/google-drive-recursive-ownership/issues/24#issuecomment-432828128, or mute the thread https://github.com/notifications/unsubscribe-auth/ALjGysIITkGkZUZa2TkCYkCEWEv4ZTOQks5uoNZbgaJpZM4X4hN2 .

davidstrauss commented 5 years ago

Sounds like a plan!

davidstrauss commented 5 years ago

I've actually just handled updating the README to instruct people to replace the sample credentials.