search

davidteren / lpx_links

Gets the additional content download links for Logic Pro X
http://davidteren.github.io/lpx_links
107 stars 27 forks source link

Logic Pro X renamed to just Logic Pro #12

Closed joldor closed 1 year ago

joldor commented 2 years ago

Hi David,

Back in 2020 the Logic Pro X app was renamed to just "Logic Pro".

Can you please update line 10 of lpx_links/lib/file_helpers.rb from 

'/Applications/Logic Pro X.app/Contents/Resources'

to something like 

`/Applications/Logic Pro\*.app/Contents/Resources`

?

Thanks.

QuakersOat commented 2 years ago

Jordito, this is unnecessary and actually would break things for people on older versions. Apple was smart enough to automatically create a symlink for backwards compatibility, I just checked it out.

davidteren commented 2 years ago

Thanks for checking it out @QuakersOat.

@jordito does the current path break for for you?

joldor commented 2 years ago

Hi Guys,

@QuakersOat thanks for the feedback. I realized that what I suggested above is not even valid Ruby (time to learn Ruby I guess), but my intention was precisely to suggest something that would allow the data for the links to be extracted regardless of whether the app was called "Logic Pro" or "Logic Pro X".

@davidteren , the day I opened this issue, executing your lpx_links.rb script did not work at all for me on macOS 11.6.8 with Logic Pro 10.7.4. All I got was the following output in my terminal:

LogicPro

I've tried again recently and after a few tries it suddenly started working (not sure why), but I still get this output in my terminal apparently coming from your plist_file_name function with the embedded shell commands:

sh: line 0: cd: /Applications/Logic Pro X.app/Contents/Resources: No such file or directory

Do either of you confirm this behavior?

@QuakersOat, I'm curious about that symlink you mentioned. Where are you seeing it?

Thanks.