daviwil / dotfiles

[MIRROR] The path to GNUrvana
https://config.daviwil.com
MIT License
829 stars 177 forks source link

Evil magit conflict on update #4

Closed NicolasIriarte closed 3 years ago

NicolasIriarte commented 3 years ago

Recently evil-magit is part of evil-collection. So the (use-package evil-magit ... is no longer needed (cause errors on magit-status).

More info: here

daviwil commented 3 years ago

Yep, unfortunately I haven't been able to update my config just yet because Guix (which I use to manage my Emacs packages) hasn't updated evil-collection yet to a version with the evil-magit bindings moved over.

NicolasIriarte commented 3 years ago

I'll let this issue open until fixed. I'm reviewing (almost) all your configuration and I find some other littles issues. Do you prefer continuing this thread or making new ones with every one?

daviwil commented 3 years ago

Do you prefer continuing this thread or making new ones with every one?

Sorry I forgot to reply to this! Sure, definitely file issues for anything you find.

Finally got the evil-magit issue fixed as of https://github.com/daviwil/dotfiles/commit/5dc7f6b205962d4bfd0e6e20701b9c8c6d04e165