search

davydden / homebrew-dealiisuite

dealii suite using linuxbrew
6 stars 1 forks source link

Parse command line arguments for install script #15

Closed jppelteret closed 8 years ago

jppelteret commented 9 years ago

Added options for user to set HB/LB installation path and target bash file.

jppelteret commented 9 years ago

@davydden If you'd like, I can make a switch between system libraries and Homebrew libraries as well.

davydden commented 9 years ago

looks good, thanks! Please, merge yourself, optionally after removing --default.

davydden commented 9 years ago

p.s. i wouldn't bother with the switch for now, just to keep the script simple.

jppelteret commented 9 years ago

I've found myself having to reinstall Linuxbrew on my desktop machine and it doesn't like the use of the system libraries for some reason. I'm not willing to dig into it right now but I've got a hard-coded switch for the system libraries in place now. I'll add it later, but with the default as using the system libraries.

davydden commented 9 years ago

i see, that's strange...

jppelteret commented 9 years ago

Yip, I agree. But I've got work to do so I just need to solve the problem for now. I'll investigate more later in the week.

davydden commented 9 years ago

The updated script with system libraries looks good to me!

davydden commented 8 years ago

why don't we have this one merged yet? ;-)

jppelteret commented 8 years ago

Err, I don't think so. I seem to recall testing this and that it worked fine. Do you want me to double-check this during the week?

davydden commented 8 years ago

let's update sha's for patches and then double check it with the new script

jppelteret commented 8 years ago

Sounds like a good idea. I'll do that as soon as I can during the week.

jppelteret commented 8 years ago

Ok so I've checked this script with and without system libraries on Ubuntu 15.10. Seems to work fine now that building Trilinos with Fortran is disabled. As this is the case, one need not install GCC via linuxbrew when not using the system libraries (line 107). I think that this is alright to be merged now if you think its fine.

davydden commented 8 years ago

so when system libraries are off we actually use gcc from the system, right? i guess it's fine to use ubuntu's gcc, as long as it works...

thanks a lot for cleaning it up.

jppelteret commented 8 years ago

Yes thats right. I thought that it was a safe bet that the system (well, Ubuntu) would still provide a working compiler. If we extend the script work for other distributions (e.g. those that don't have apt-get) then we can reassess this choice.