day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
632 stars 68 forks source link

[Bug]: Backspace not working when editing path #324

Open Jarzka opened 2 years ago

Jarzka commented 2 years ago

What happened?

When editing path in path inspector, the backspace key is not working (it does nothing, should delete character at cursor).

I'm running macOS, but this bug also occurs on my colleague's Linux machine. Occurs in the latest version (1.1.13), did not happen earlier.

10x Version

1.1.13

Reagent Version

1.1.0

React Version

17.0.2

re-frame Version

1.2.0

What browsers are you seeing the problem on?

Chrome

Relevant console output

No response

MawiraIke commented 2 years ago

@Jarzka can you please confirm if this issue is still happening in the latest version of re-frame-10x (1.2.0) I have tried to run the example project on an Ubuntu machine and I can not reproduce this issue on 10x version 1.2.0 and Chrome version 96.0.4664.45. In case you are still getting the error, are there any errors or changes noticed? Thanks.

Jarzka commented 2 years ago

I'm now running day8.re-frame/re-frame-10x {:mvn/version "1.2.0"}

Unfortunately this bug is still present on macOS Monterey and Chrome 96.0.4664.55. I simply click "path inspector", type some characters and then press backspace, and nothing happens (should delete characters at the left side of the cursor). Also happens on Firefox.

Delete key works, however. It deletes characters at the right side of the cursor.

EDIT: I asked my colleagues about this. One using macOS does not experience this, but another with Windows does.

MawiraIke commented 2 years ago

Okay @Jarzka thanks for the update, I am looking into this.

Edit: I remember seeing this bug showing intermittently sometime back while working on Windows although it somehow stopped showing and backspace works correctly now. If I remember correctly, the workaround I used when it showed was to select text (e.g. with shift and arrow keys) and then pressing backspace. I am checking to see how this could be happening.

ertugrulcetin commented 2 years ago

I'm also having this problem. Using OSX 10.15.7 Catalina and Brave Browser - Version 1.34.80 Chromium: 97.0.4692.71 (Official Build) (x86_64)