day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
632 stars 68 forks source link

[Enhancement]: Add toggle option to turn on/off path annotations for app-db #341

Closed MawiraIke closed 2 years ago

MawiraIke commented 2 years ago

What do you suggest?

The path annotation feature in re-frame-10x 1.2.0 is a nice addition which allows users to copy paths of objects in the app-db and also copy nested children within the app-db etc. However, this processing takes longer when the app-db is larger. For small maps without deep nesting the difference in performance is not really visible but in cases when the app-db is larger than 3mb, I have got speeds of about 7 seconds. This is quite a lot and might render 10x unusable for some users/use cases. To this end, a PR is needed to add a toggle option to turn on/off rendering path annotations. When this option is off, we will call (body ...) without the render-paths? option