search

day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
631 stars 68 forks source link

[Bug]: react-highlight.js prevents me from updating to React 17 #381

Closed lilactown closed 1 year ago

lilactown commented 1 year ago

What happened?

re-frame-10x requires us to install react-highlight.js in our project. This dependency hasn't been updated in years, and it declares a peer dependency of React 14/15/16. This makes it very awkward for us to update to React 17, since npm tries to keep peer dependencies honest, and I'm not sure if it has been tested at all.

react-highlight is an alternative that seems to be more up to date and from a cursory reading of the README, seems like it could be a drop in replacement.

10x Version

1.5.0

Reagent Version

1.1.0

React Version

17

re-frame Version

1.2.0

What browsers are you seeing the problem on?

No response

Relevant console output

No response

M-sleeper commented 1 year ago

I think bumping the superstructor/re-highlight dependency to 2.0.2 will resolve this.

superstructor commented 1 year ago

Correct. Was fixed in https://github.com/superstructor/re-highlight/pull/3

kimo-k commented 1 year ago

Fixed in b9edaa9