day8 / re-frame

A ClojureScript framework for building user interfaces, leveraging React
http://day8.github.io/re-frame/
MIT License
5.42k stars 715 forks source link

[Bug] [Docs]: Simple app example docs out of sync with code in repo #758

Closed gulllberg closed 1 year ago

gulllberg commented 2 years ago

What happened?

I recently started looking into re-frame (looks great, I wish the JS community was as wise when it comes to architecture) and read through the docs. The follow-along with simple app docs https://day8.github.io/re-frame/dominoes-live/ was out of sync with the code (which the docs link to) https://github.com/day8/re-frame/blob/master/examples/simple/src/simple/core.cljs. Most notably the views differed, but there are other minor differences too (e.g. the name of the mount-ui/render function).

(If you want I could have a go at fixing it, but as mentioned I'm very much a re-frame novice. I would need to know which of the two is the correct version).

Version

1.2.0

What runtimes are you seeing the problem on?

Google Chrome

Relevant console output

No response