dayjs / dayjs-website

⏰Day.js website repo
http://day.js.org/
MIT License
65 stars 228 forks source link

Suggestion: little notice in tables for short forms of units for m and M being for minutes and months #31

Closed ibrahimcesar closed 3 years ago

ibrahimcesar commented 3 years ago

Hello,

Maybe I'm just an edge case, but since english is not my first language, sometimes the language is another obstacle for me achieve my purposes. I spent a great amount of time, wrestling with a problem only later I identified: in the docs is said that units are case insensitive, so Months, MONTHS, etc. But of course, the documentation didn't explicit said that this was the case for short hands, and I was using with this expectations.

Now, I know I should compare the table, where is very explicit the relationship, short forms being only an alternative to units names and maybe this is just a little patch for a problem only I had, but I decided to submit anyway, if thinks it makes sense a little extra help for developers like me :)

I only append my notice in the texts where the table appears and of course, maybe I wrote in the wrong way.

Great job! I like a lot this lib.

iamkun commented 3 years ago

Nice suggestion.

We can make it shorter: Note, short forms are case sensitive.

And, please use single quotes instead.

ibrahimcesar commented 3 years ago

Updated with your comments!

Thanks,

iamkun commented 3 years ago

Cheers