search

dayn-1 / pe

0 stars 0 forks source link

Names must be unique #2

Open dayn-1 opened 3 months ago

dayn-1 commented 3 months ago

TutorRec does not allow for multiple persons with the same name.

In real life, there are common full names such as "Ryan Tan" or "Tan Wei Jie". Although a possible workaround will be naming them "Ryan Tan1" and Ryan Tan2", this will inconvenience the user and make it difficult to use.

To replicate, perform the following commands:

  1. add n/ Ryan Tan
  2. add n/ Ryan Tan

Behaviour: "This person already exists in the address book".

nus-se-bot commented 2 months ago

Team's Response

Fair point, but as primary school students there isn't many identifiers aside from the names. Thus, it has to be the unique identifier.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]