daytonamelia / Deduper-daytonamelia

Deduper assignment for BGMP Bi624
0 stars 0 forks source link

Pseudocode Feedback #3

Open carlyham opened 1 week ago

carlyham commented 1 week ago

Hi Amelia! Everything here looks really good! Your strategy in your pseudocode seems reasonable to me and I appreciated that in places where you were not certain what you would do (ie saving reads to memory) you talked through your thought process as to why you might do something different. I really liked your high level functions! The example inputs/outputs were really helpful for understanding your strategy. I've noticed that a few people (I think I did this as well) decided to make their bitwise flag check a function and not part of the code body. I'm not sure if there's an advantage to doing that speed-wise, but it's something to think about! Overall really nice job!