dbeley / rymscraper

Python library to extract data from rateyourmusic.com.
MIT License
168 stars 25 forks source link

Add encoding parameter to not get error on Windows #37

Closed Vuizur closed 1 year ago

Vuizur commented 1 year ago

First of all, thanks for creating this very cool project!

If you currently want to install rymscraper on windows as a package over git like pip install git+https://github.com/dbeley/rymscraper (I tested it with poetry), you get an error because for windows the default encoding is not utf-8, which causes setup.py to crash when reading the description file. This PR should fix this.

dbeley commented 1 year ago

Hey, thanks for this PR :)